Remove unsetting of NetCoreTargetingPackRoot to allow package pruning #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
approved these changes
Sep 29, 2025
This was referenced Sep 29, 2025
This was referenced Oct 10, 2025
This was referenced Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #61
Package pruning in .NET 10 requires
NetCoreTargetingPackRootto be set. Previously, we unset that property to isolate the build environment from machine configuration.To resolve the issue, we're removing our unsetting of this property so that package pruning can work as expected. The more officially supported way to instead enforce a consistent SDK version is via global.json. However, enforcing that is a bigger change that may break some workflows.
As a result, we're going to ship this change in two pieces: this piece, which is non-breaking and unblocks .NET 10 SDK adoption. The global.json enforcement will come later in #69.