Skip to content

Conversation

akarnokd
Copy link
Collaborator

@akarnokd akarnokd commented May 3, 2018

This PR adds the Observable.RetryWhen extension method and operator. One can use the handler to have the Exception of the main source turned into a regular value and reacted to via an IObservable flow. This allows performing timed and/or retries by manipulating those errors via standard Rx operators.

@akarnokd
Copy link
Collaborator Author

akarnokd commented May 3, 2018

The build failed for some reason (or I can't see the reason on the VSTS dashboard).

@clairernovotny
Copy link
Contributor

I don't see anything either, which is weird. touching the PR should trigger another build.

@clairernovotny clairernovotny changed the base branch from develop to master May 3, 2018 23:00
@akarnokd
Copy link
Collaborator Author

akarnokd commented May 3, 2018

We are getting somewhere:

[xUnit.net 00:00:31.1080629] ReactiveTests.Tests.QbservableTest.Qbservable_Observable_Parity [FAIL]
       Missing Qbservable operator: RetryWhen
       Expected: True
       Actual:   False
       Stack Trace:
            at ReactiveTests.Tests.QbservableTest.Qbservable_Observable_Parity()

I can see a Qbservable.Generated.cs file. How is it regenerated? Do I have to manually add a partial class like Qbservable.Joins.cs?

@clairernovotny
Copy link
Contributor

I'll need to take a look and remember :)

@akarnokd
Copy link
Collaborator Author

akarnokd commented May 3, 2018

There is this HomoIcon program that should generate those files but it hasn't been updated to support the new project structuring.

@clairernovotny clairernovotny merged commit d1f88cc into dotnet:master May 26, 2018
@akarnokd akarnokd deleted the RetryWhen branch May 26, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants