Skip to content

Conversation

bartdesmet
Copy link
Collaborator

Remove some code that's no longer used, and simplify the exception singleton used. It doesn't need to have a unique type (and we never perform type checks); we should just never leak the instance. Also addresses a few warnings:

src\System.Reactive\Internal\ExceptionHelper.cs(101,30): warning CA1032: Add the following constructor to TerminatedException: public TerminatedException(string message)
src\System.Reactive\Internal\ExceptionHelper.cs(101,30): warning CA1032: Add the following constructor to TerminatedException: public TerminatedException(string message, Exception innerException)
src\System.Reactive\Internal\ExceptionHelper.cs(101,30): warning CA1064: Exceptions should be public

@bartdesmet bartdesmet merged commit ba9ea4e into main Oct 7, 2020
@bartdesmet bartdesmet deleted the dev/bartde/remove_more_dead_code branch October 7, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant