Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
#if
checks that are always true. Flip the#if
checks to encode the exceptional case rather than the common case, thus reducing the number of#define
s (e.g.NO_TRACE
andHAS_REMOTING
are the exceptions to the rule).NB: For the time being, I'm leaving
HAS_WINRT
alone. I'll review these cases separately, because they're often combined withCRIPPLED_REFLECTION
which also needs some closer look. If we can deprecate UAP 10.0 at some point, a lot more#if
checks can go away.NB: The
PREFER_ASYNC
stuff was used to control[Obsolete]
attributes on various blocking members. I'll look into the steps towards final removal of these, given they've been marked as such for a long time (will review the history to make a call; alternatively, we can make the warning stronger and start removing a lot of code by layering the blocking ones on top of the non-blocking ones using the pattern we expect users to write, e.g..GetAwaiter().GetResult()
).