Consider architecture when generating guidance link for retargeting #9847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phenning
force-pushed
the
phenning/archLink
branch
from
7767f78 to
92297b7
Compare
drewnoakes
approved these changes
Oct 29, 2025
| return null; | ||
| } | ||
|
|
||
| string architecture = _environment.ProcessArchitecture.ToString().ToLowerInvariant(); |
Member
There was a problem hiding this comment.
Consider reusing:
Avoids an allocation.
Member
Author
There was a problem hiding this comment.
refactored out to an extensions method and renamed
| } | ||
|
|
||
| private RetargetSDKDescription(string sdkVersion) : base( | ||
| private RetargetSDKDescription(string sdkVersion, string arch) : base( |
Member
There was a problem hiding this comment.
Consider taking the Architecture enum here so that it's clear what domain of values are valid. Then do the conversion to lower case whatever internally when formatting a string.
* DotNetEnvironment.GetArchitectureSubKey(Architecture) into an Architecture extension method. * Updated old call sites * Updated this PR to pass the Architecture to RetargetSDKDescription and do the string replacement there. * Updated unit test to verify expected architecture is present in the suggesion Url.
drewnoakes
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.