Report error when generating serializer for model from ref assembly #9520
+117
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
reviewed
May 22, 2025
| public const string Category = "Usage"; | ||
|
|
||
| private static readonly DiagnosticDescriptor Rule = new DiagnosticDescriptor( | ||
| RuleId, Title, MessageFormat, Category, DiagnosticSeverity.Warning, isEnabledByDefault: true, description: Description); |
There was a problem hiding this comment.
IMO we should make this an error, since it is most likely going to break something
ReubenBond
reviewed
May 22, 2025
| { | ||
| public const string RuleId = DiagnosticRuleId.ReferenceAssemblyWithGenerateSerializer; | ||
| public const string Title = "[GenerateSerializer] used in a reference assembly"; | ||
| public const string MessageFormat = """ |
There was a problem hiding this comment.
Perhaps MessageFormat & Description need to be swapped, essentially, so that the description includes the detail and message format only includes the top line "The type {0} is marked with [GenerateSerializer] in a reference assembly"
There was a problem hiding this comment.
swapped. let me know if you think this is fine
ReubenBond
changed the title
ReubenBond
approved these changes
May 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We suspect inability to serialize private fields because of the ref assembly. Therefore I am adding a check on code generator, which will emit a diagnostic if the target model is coming from the ref assembly.
Also moved ruleIds to separate file to easily nagivate accross different existing diagnosticIds.
Example:
Fixes #9265
Microsoft Reviewers: Open in CodeFlow