Skip to content

Stop logging DynamoDB TTL error when its not necessary #9500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

Stop logging DynamoDB TTL error when its not necessary #9500

merged 1 commit into from
May 21, 2025
+5 −4

Conversation

binginsin
Copy link
Contributor

@binginsin binginsin commented May 15, 2025 •
edited by dotnet-policy-service bot
Loading

Fixes #9499

Microsoft Reviewers: Open in CodeFlow

@DainiusCerniauskasAngstrom
Copy link

Unit test that failed is called UnitTests.TimerTests.ReminderTests_TableGrain.Rem_Grain_Basic_ListOps which by the sounds of it has nothing to do with my change. The test already has a line await Task.Delay((period + LEEWAY).Multiply(2)); // giving some leeway, including leeway in each period to minimize flakiness which tells me the test is probably flaky and is a false positive. Could someone check / rerun them?

@ReubenBond ReubenBond merged commit 025f840 into dotnet:main May 21, 2025
27 of 28 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ReubenBond ReubenBond ReubenBond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DynamoDB storage provider logging TTL errors when it shouldn't
3 participants
@binginsin @DainiusCerniauskasAngstrom @ReubenBond