Skip to content

tests(source-generator): additional tests for complex scenarios #9470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2025

Conversation

Meir017
Copy link
Contributor

@Meir017 Meir017 commented Apr 30, 2025

from https://github.com/dotnet/orleans/actions/runs/14795101967/job/41540349265?pr=9470

Module Line Branch Method
Orleans.CodeGenerator 72.84% 66.36% 73.44%

orleans-source-generator-coverage.zip

not quite sure what source-code would trigger this -

case FieldAccessorDescription accessor when accessor.InitializationSyntax == null:
//[UnsafeAccessor(UnsafeAccessorKind.Method, Name = "set_Amount")]
//extern static void SetAmount(External instance, int value);
return
and this
case FieldAccessorDescription accessor when accessor.InitializationSyntax == null:
//[UnsafeAccessor(UnsafeAccessorKind.Method, Name = "set_Amount")]
//extern static void SetAmount(External instance, int value);
return

Microsoft Reviewers: Open in CodeFlow

@ReubenBond ReubenBond force-pushed the tests/source-generator branch from 5692b51 to a533f4f Compare June 6, 2025 16:14
@ReubenBond ReubenBond force-pushed the tests/source-generator branch from a533f4f to 41f3494 Compare June 6, 2025 16:15
@ReubenBond ReubenBond force-pushed the tests/source-generator branch from 41f3494 to 76daef7 Compare June 7, 2025 04:21
@ReubenBond ReubenBond merged commit 4bc3b60 into dotnet:main Jun 10, 2025
27 of 28 checks passed
@Meir017 Meir017 deleted the tests/source-generator branch June 11, 2025 03:25
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants