Add additional context and logging when a grain constructor throws #9399
+47
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
force-pushed
the
fix/facet-error-message
branch
from
95a49ab to
292b440
Compare
ReubenBond
force-pushed
the
fix/facet-error-message
branch
2 times, most recently
from
dd9ba07 to
78be991
Compare
ReubenBond
force-pushed
the
fix/facet-error-message
branch
from
78be991 to
677aa2c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds clearer error logs & exceptions when a grain class cannot be constructed.
It also adds a specific, more informative, exception for the case where a grain constructor parameter has a
[PersistentState(...)]attribute but the parameter type is notIPersistentState<T>.Microsoft Reviewers: Open in CodeFlow