Prefer const over readonly #8533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
approved these changes
Aug 16, 2023
ReubenBond
force-pushed
the
jamest/access
branch
from
05ad9b4 to
0921996
Compare
ReubenBond
approved these changes
Mar 20, 2025
ReubenBond
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that all classes, interfaces, class members, etc. have accessibility modifiers present. This was the result of a tool run by Visual Studio followed by a lot of manual cleanup (for some reason, the tool decided to remove readonly modifiers, which was odd so I added them back).
In one or two cases only, I changed a private readonly to a private const where it made sense to do so as part of that manual cleanup.
Microsoft Reviewers: Open in CodeFlow