Skip to content

[vs17.13] Binlog not produced for C++ project on Visual Studio Load Fix #11756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

[vs17.13] Binlog not produced for C++ project on Visual Studio Load Fix #11756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
588aa6b
revert "use collection expressions in (non-test) sources (#10758)"
surayya-MS Apr 23, 2025
1f786d4
Revert "revert "use collection expressions in (non-test) sources (#10…
surayya-MS Apr 23, 2025
d9df9f9
fix include BinaryLogger
surayya-MS Apr 23, 2025
3e24c04
fix
surayya-MS Apr 23, 2025
c99224c
bump version
surayya-MS Apr 23, 2025
2b52a14
fix another misplaced brackets
surayya-MS Apr 24, 2025
0a7e311
Revert "fix another misplaced brackets"
surayya-MS Apr 24, 2025
55aaab8
Revert "fix another misplaced brackets"
surayya-MS Apr 24, 2025
23803dc
Merge branch 'cpp-binlog-fix' of https://github.com/surayya-MS/msbuil…
surayya-MS Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the MIT license. See License.txt in the project root for full license information. -->
<Project>
<PropertyGroup>
<VersionPrefix>17.13.25</VersionPrefix>
<VersionPrefix>17.13.26</VersionPrefix>
<DotNetFinalVersionKind>release</DotNetFinalVersionKind>
<PackageValidationBaselineVersion>17.12.6</PackageValidationBaselineVersion>
<AssemblyVersion>15.1.0.0</AssemblyVersion>
Expand Down
2 changes: 1 addition & 1 deletion src/Build/BackEnd/BuildManager/BuildManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ IEnumerable<ILogger> AppendDebuggingLoggers(IEnumerable<ILogger> loggers)

var logger = new BinaryLogger { Parameters = binlogPath };

return (loggers ?? [logger]);
return (loggers ?? []).Concat([logger]);
}

void InitializeCaches()
Expand Down
Loading