Skip to content

Conversation

@YuliiaKovalova
Copy link
Member

@YuliiaKovalova YuliiaKovalova commented Jan 2, 2025

Fixes ##11090

Context

E2E tests for BuildCheck require to have set of MSBuild nuget packages to run.
To avoid having a race condition on the build machines, we agreed to use the existing package generation approach locally too, so no additional logic required.

@YuliiaKovalova YuliiaKovalova marked this pull request as ready for review January 3, 2025 11:19
@YuliiaKovalova YuliiaKovalova requested a review from a team as a code owner January 3, 2025 11:19
@JanKrivanek
Copy link
Member

Just curious - what is the extra time added to a local dev build when performing incremental build with a single change in one of our projects?

Just trying to see if this is something no worth of any extra thoughts, or if we should try to think about a way how to still keep inner loop quick (e.g. keep the previous approach, while condition on some extra thing passed in CI/official build, that would force skipping the packing in preparation of test assets)

@YuliiaKovalova
Copy link
Member Author

Just curious - what is the extra time added to a local dev build when performing incremental build with a single change in one of our projects?

Just trying to see if this is something no worth of any extra thoughts, or if we should try to think about a way how to still keep inner loop quick (e.g. keep the previous approach, while condition on some extra thing passed in CI/official build, that would force skipping the packing in preparation of test assets)

I haven't noticed any significant wall clock time changes on my device.

@YuliiaKovalova YuliiaKovalova merged commit 08729bf into dotnet:main Jan 6, 2025
10 checks passed
This was referenced Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants