Skip to content

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 25, 2024

Microsoft.IO.Redist, System.Bufferes, System.Memory and more recently shipped from the dotnet/maintenance-packages repository. Update binding redirects to the latest assembly version in order for them to be available on .NET Framework msbuild.

This change will require coordination with VS. Even more importantly, this change also updates System.Memory which according to the documentation in Versions.props is a breaking change.

Microsoft.IO.Redist, System.Bufferes, System.Memory and more recently shipped from the dotnet/maintenance-packages repository. Update binding redirects to the latest assembly version in order for them to be available on .NET Framework msbuild.

This will require coordination with VS.
@ViktorHofer ViktorHofer requested a review from a team as a code owner November 25, 2024 19:38
@ViktorHofer
Copy link
Member Author

cc @carlossanlop @ericstj

@ViktorHofer
Copy link
Member Author

@carlossanlop looks like we need to backport the new m-p packages from SBRP main to release/9.0 as msbuild uses SBRP 9.0.

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs the same VS coordination as #11145, and I think we can slot it in right after that one (since @MarkOsborneMS has currently gotten that one working so it's first in line).

@rainersigwald
Copy link
Member

@AArnott is interested in doing this in VS now and we're optimistic that it's not going to mess with #11145 so I'll pick this up.

@rainersigwald
Copy link
Member

Experimental insertion (by itself): https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/606809

rainersigwald and others added 2 commits March 10, 2025 16:57
This will ensure that we're testing compatibility, and avoid requiring
updating the dependencies of the ProjectCachePlugin.
@ViktorHofer
Copy link
Member Author

@rainersigwald I resolved merge conflicts that caused the build to fail

@rainersigwald
Copy link
Member

Current build breaks will be fixed by #11563; testing combination at https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=11197287.

@rainersigwald rainersigwald changed the base branch from main to vs17.14 March 28, 2025 19:24
@rainersigwald
Copy link
Member

Perf results on https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/619314 looked good so I merged with and retargeted to 17.14.

@rainersigwald rainersigwald enabled auto-merge (squash) March 28, 2025 19:58
@rainersigwald rainersigwald merged commit 0457980 into vs17.14 Mar 28, 2025
9 checks passed
@rainersigwald rainersigwald deleted the ViktorHofer-patch-1 branch March 28, 2025 20:05
@YuliiaKovalova
Copy link
Member

@ViktorHofer fyi: #11659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants