-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update assembly versions to latest for packages that recently shipped #11038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Microsoft.IO.Redist, System.Bufferes, System.Memory and more recently shipped from the dotnet/maintenance-packages repository. Update binding redirects to the latest assembly version in order for them to be available on .NET Framework msbuild. This will require coordination with VS.
|
@carlossanlop looks like we need to backport the new m-p packages from SBRP main to release/9.0 as msbuild uses SBRP 9.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs the same VS coordination as #11145, and I think we can slot it in right after that one (since @MarkOsborneMS has currently gotten that one working so it's first in line).
…maintenance-packages
(yet; VS isn't doing so right now)
|
Experimental insertion (by itself): https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/606809 |
This reverts commit f60e285.
Conflicts: eng/Versions.props
This will ensure that we're testing compatibility, and avoid requiring updating the dependencies of the ProjectCachePlugin.
|
@rainersigwald I resolved merge conflicts that caused the build to fail |
|
Current build breaks will be fixed by #11563; testing combination at https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=11197287. |
|
Perf results on https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/619314 looked good so I merged with and retargeted to 17.14. |
|
@ViktorHofer fyi: #11659 |
Microsoft.IO.Redist, System.Bufferes, System.Memory and more recently shipped from the dotnet/maintenance-packages repository. Update binding redirects to the latest assembly version in order for them to be available on .NET Framework msbuild.
This change will require coordination with VS. Even more importantly, this change also updates System.Memory which according to the documentation in Versions.props is a breaking change.