Skip to content

Add final branding VS17.12 #10697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Add final branding VS17.12 #10697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e7f91e
Add final branding
maridematte Sep 24, 2024
53483cc
disable customCheck tests
maridematte Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the MIT license. See License.txt in the project root for full license information. -->
<Project>
<PropertyGroup>
<VersionPrefix>17.12.0</VersionPrefix>
<VersionPrefix>17.12.0</VersionPrefix><DotNetFinalVersionKind>release</DotNetFinalVersionKind>
<PackageValidationBaselineVersion>17.11.4</PackageValidationBaselineVersion>
<AssemblyVersion>15.1.0.0</AssemblyVersion>
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
Expand Down
8 changes: 4 additions & 4 deletions src/BuildCheck.UnitTests/EndToEndTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ public void EditorConfig_SeverityAppliedCorrectly(string BC0101Severity, string?
}
}

[Fact]
[Fact(Skip = "https://github.com/dotnet/msbuild/issues/10702")]
public void CheckHasAccessToAllConfigs()
{
using (var env = TestEnvironment.Create())
Expand Down Expand Up @@ -454,7 +454,7 @@ public void NoEnvironmentVariableProperty_DeferredProcessing(bool warnAsError, b
}
}

[Theory]
[Theory(Skip = "https://github.com/dotnet/msbuild/issues/10702")]
[InlineData("CheckCandidate", new[] { "CustomRule1", "CustomRule2" })]
[InlineData("CheckCandidateWithMultipleChecksInjected", new[] { "CustomRule1", "CustomRule2", "CustomRule3" }, true)]
public void CustomCheckTest_NoEditorConfig(string checkCandidate, string[] expectedRegisteredRules, bool expectedRejectedChecks = false)
Expand Down Expand Up @@ -487,7 +487,7 @@ public void CustomCheckTest_NoEditorConfig(string checkCandidate, string[] expec
}
}

[Theory]
[Theory(Skip = "https://github.com/dotnet/msbuild/issues/10702")]
[InlineData("CheckCandidate", "X01234", "error", "error X01234")]
[InlineData("CheckCandidateWithMultipleChecksInjected", "X01234", "warning", "warning X01234")]
public void CustomCheckTest_WithEditorConfig(string checkCandidate, string ruleId, string severity, string expectedMessage)
Expand All @@ -514,7 +514,7 @@ public void CustomCheckTest_WithEditorConfig(string checkCandidate, string ruleI
}
}

[Theory]
[Theory(Skip = "https://github.com/dotnet/msbuild/issues/10702")]
[InlineData("X01236", "Something went wrong initializing")]
// These tests are for failure one different points, will be addressed in a different PR
// https://github.com/dotnet/msbuild/issues/10522
Expand Down