Fix DisplayAlert to properly pass the cancel parameter to DisplayAlertAsync
#31474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@thisisthekap! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Sep 4, 2025
| => DisplayAlertAsync(title, message, null, cancel, flowDirection); | ||
|
|
||
| /// <inheritdoc cref="DisplayAlertAsync(string, string, string, string, FlowDirection)"/> | ||
| [Obsolete("Use DisplayAlertAsync instead")] |
There was a problem hiding this comment.
A quick note, This is an [Obsolete] method marked for removal. Users are explicitly directed to use DisplayAlertAsync instead, so, the change fixes a bug in code that should ideally not be used.
There was a problem hiding this comment.
I am aware that this method is marked for removal. But as it is used (e.g. by https://github.com/PrismLibrary/Prism), we need to make sure that the method works properly.
jfversluis
approved these changes
Sep 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed ArgumentNullException in
Page.DisplayAlert(string title, string message, string accept, string cancel, FlowDirection flowDirection).Issues Fixed
Fixes #31473