Skip to content

Conversation

@morning4coffe-dev
Copy link
Contributor

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

This pull request adds support for microphone permission handling on Windows, including the ability to check and request microphone access. It also introduces corresponding tests and updates platform-specific manifest files to declare microphone permissions, ensuring proper functionality and compliance across Windows, Android, iOS, and MacCatalyst.

Issues Fixed

In a popup summoned by Permissions.RequestAsync<Permissions.Microphone>() I denied the permission. Now every call to Permissions.RequestAsync<Permissions.Microphone> or Permissions.CheckStatusAsync<Permissions.Microphone> returns Granted.

Tests

  • Introduced new device tests for microphone permissions, verifying both denied and granted scenarios with human interaction on all supported platforms.

Fixes #31413

Copilot AI review requested due to automatic review settings September 2, 2025 09:38
@morning4coffe-dev morning4coffe-dev requested a review from a team as a code owner September 2, 2025 09:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Windows platform support for microphone permission handling in .NET MAUI Essentials, addressing an issue where permission status was incorrectly returned as Granted even after denial. The implementation provides proper checking and requesting of microphone access permissions on Windows.

Key changes:

  • Implements Windows-specific microphone permission checking and requesting logic
  • Adds comprehensive device tests for microphone permissions with human interaction scenarios
  • Updates platform manifest files to declare required microphone permissions

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

File Description
src/Essentials/src/Permissions/Permissions.windows.cs Implements microphone permission logic for Windows using MediaCapture and DeviceAccessInformation APIs
src/Essentials/test/DeviceTests/Tests/Microphone_Tests.cs Adds comprehensive device tests for microphone permission denied/granted scenarios
src/Essentials/src/PublicAPI/net-windows/PublicAPI.Unshipped.txt Documents new public API methods for Windows microphone permissions
Platform manifest files (iOS, MacCatalyst, Android, Windows) Adds microphone permission declarations across all supported platforms

@jsuarezruiz jsuarezruiz added area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info platform/windows labels Sep 3, 2025
@PureWeen PureWeen merged commit 2522ae4 into net10.0 Sep 8, 2025
150 checks passed
@PureWeen PureWeen deleted the fix-31413 branch September 8, 2025 16:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info platform/windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants