Skip to content

Conversation

@jsuarezruiz
Copy link
Contributor

Description of Change

This PR re-enables the iOS NativeAOT and Mono full trimming tests that were previously commented out due to trimmer warnings from ObjCRuntime code.

This PR made the following changes:

  • Re-enabling the commented test cases that were previously failing.
  • Keep TrimmerSingleWarn=false for NativeAOT builds to suppress detailed trimmer warnings from external iOS platform code

Let's try with the latest changes and check the results.

Issues Fixed

Fixes #29059

@jsuarezruiz jsuarezruiz marked this pull request as ready for review September 3, 2025 09:34
Copilot AI review requested due to automatic review settings September 3, 2025 09:34
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner September 3, 2025 09:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables iOS NativeAOT and Mono full trimming tests that were previously disabled due to trimmer warnings from ObjCRuntime code. The changes focus on restoring test coverage while managing the underlying platform-specific warning issues.

  • Re-enables two commented iOS test cases for full trimming scenarios
  • Retains TrimmerSingleWarn=false configuration to suppress external iOS platform warnings
  • Adds documentation explaining the reasoning for disabling trimmer warnings

@rmarinho rmarinho merged commit 56d144c into net10.0 Sep 6, 2025
148 checks passed
@rmarinho rmarinho deleted the fix-29059 branch September 6, 2025 22:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants