[Testing] Added new SafeAreaEdges categories in UITest and created separate lane to run the category in API 36 #31355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
community ✨
ghost
added
area-testing
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
marked this pull request as ready for review
There was a problem hiding this comment.
Pull Request Overview
This PR adds dedicated testing infrastructure for SafeAreaEdges functionality on Android API 36 using a Pixel 9 emulator configuration. The changes enable isolated testing of safe area behavior with proper device-specific screen dimensions and UI adjustments.
Key changes:
- Added SafeAreaEdges test category and pipeline configuration for Android API 36
- Integrated Pixel 9 emulator support with device-specific screen handling
- Updated test infrastructure to accommodate different Android device configurations
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| UITestCategories.cs | Adds SafeAreaEdges test category constant |
| UITest.cs | Updates device validation and screenshot cropping for API 36/Pixel 9 |
| BoxViewFeatureTests.cs | Temporarily changes test category to SafeAreaEdges for pipeline validation |
| ui-tests.yml | Adds API 36 support and dedicated SafeAreaEdges test stage |
| ui-tests-steps.yml | Adds deviceType parameter for Android device skin configuration |
| Versions.props | Adds Pixel 9 device configuration for API 36 emulator |
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/BoxViewFeatureTests.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
added
the
p/0
|
@anandhan-rajagopal I see relevant failing builds. Can you have a look? |
mattleibow
reviewed
Sep 11, 2025
Comment on lines
-301
to
+306
| TestDevice.Android => 60, | ||
| TestDevice.Android => environmentName == "android-notch-36" ? 95 : 60, |
There was a problem hiding this comment.
It might be beneficial to refactor this section in net11 for better readability. But for now, this is OK to just get the ball rolling.
rmarinho
requested changes
Sep 11, 2025
There was a problem hiding this comment.
Seems something is missing ? Maybe on cake how it creates the emulator first ?
Resolved tool to path /usr/local/lib/android/sdk/cmdline-tools/latest/bin/avdmanager
Executing: /usr/local/lib/android/sdk/cmdline-tools/latest/bin/avdmanager delete avd -n Emulator_36
Error: There is no Android Virtual Device named 'Emulator_36'.
null
Error: System.Exception: The emulator did not finish booting in time.
github-project-automation
bot
moved this from Approved
to Changes Requested
in MAUI SDK Ongoing
PureWeen
requested changes
Sep 12, 2025
|
/rebase |
…BoxViewFeatureTests.cs Co-authored-by: Copilot <[email protected]>
github-actions
bot
force-pushed
the
UITestForAPI36
branch
from
786bb7e to
c6d5f5a
Compare
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request introduces a dedicated test lane and emulator configuration for running SafeAreaEdges UI tests on Android API 36, specifically using a Pixel 9 device skin. It also updates the test infrastructure and test code to support and validate this new environment. The most important changes are grouped below:
Pipeline and Emulator Configuration:
eng/Versions.propsto support SafeAreaEdges testing.eng/pipelines/common/ui-tests.yml) to include Android API 36 and created a new test stage specifically for SafeAreaEdges tests using the Pixel 9 emulator. [1] [2] [3]ui-tests-steps.ymlto accept and use adeviceType(e.g., Pixel 9). [1] [2]Test Code and Category Updates:
SafeAreaEdgestoUITestCategoriesand temporarily changed the category ofBoxView_CornerRadiusWithColorto ensure it runs in the new pipeline. [1] [2]Test Logic and Validation:
UITest.csto recognize and validate the new Pixel 9 / API 36 emulator configuration, including screen size and density checks, and adjusted screenshot cropping logic for the new device. [1] [2] [3]