Skip to content

Enhance maui-mobile developer sample with recent updates #31151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 22, 2025
Merged

Enhance maui-mobile developer sample with recent updates #31151

merged 14 commits into from
Aug 22, 2025

Conversation

@SuthiYuvaraj
Copy link
Contributor

@SuthiYuvaraj SuthiYuvaraj commented Aug 13, 2025 •
edited
Loading

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

Added updated developer sample to maui-mobile

Issues Fixed

Fixes #31069

Associated Pull Requests

dotnet/maui-samples#604
dotnet/maui-samples#611
dotnet/maui-samples#648
dotnet/maui-samples#649
dotnet/maui-samples#650
dotnet/maui-samples#651
dotnet/maui-samples#652

Output Screenshot:

Screenshot 2025-08-13 at 7 25 25 PM

@dotnet-policy-service dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Aug 13, 2025
@SuthiYuvaraj SuthiYuvaraj changed the title Port mauimobile Enhance maui-mobile developer sample with recent updates Aug 13, 2025
@SuthiYuvaraj SuthiYuvaraj marked this pull request as ready for review August 13, 2025 13:57
Copilot AI review requested due to automatic review settings August 13, 2025 13:57
@SuthiYuvaraj SuthiYuvaraj requested a review from a team as a code owner August 13, 2025 13:57
@sheiksyedm sheiksyedm added the area-templates Project templates, Item Templates for Blazor and MAUI label Aug 13, 2025
Copilot AI reviewed Aug 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@PureWeen PureWeen added this to the .NET 10.0-rc1 milestone Aug 13, 2025
@PureWeen PureWeen added the p/0 Work that we can't release without label Aug 13, 2025
@PureWeen PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Aug 13, 2025
@jfversluis
Copy link
Member

Please make sure to check also outside of these PRs, like #31152 was also in the samples but not in the templates. Can I ask you to really check and see if there are any more differences? :)

@jfversluis jfversluis self-requested a review August 14, 2025 07:53
@jfversluis jfversluis self-assigned this Aug 14, 2025
@rmarinho
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

MartyIX
MartyIX reviewed Aug 14, 2025
View reviewed changes
src/Templates/src/templates/maui-mobile/Resources/Styles/Styles.xaml Outdated
</Setter>
</Style>

<Style TargetType="Frame">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Frame deprecated? Or is it a different frame?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @MartyIX ,Frame is deprecated. I have modified the code changes accordingly , kindly check and let me know if you have any other concenrs.

@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PureWeen
Copy link
Member

/rebase

PureWeen
PureWeen requested changes Aug 19, 2025
View reviewed changes
src/Templates/src/templates/maui-mobile/App.xaml.cs Outdated

public partial class App : Application
{
public IServiceProvider ServiceProvider { get; private set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct, we don't want to create a new ServiceProvider here.

The announcement helper should get registered as a singleton into the ServiceProvider and then you add it to the ctor arguments on the VMs where it's used

@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

/rebase

@SuthiYuvaraj SuthiYuvaraj marked this pull request as ready for review August 21, 2025 11:19
@dotnet dotnet deleted a comment from azure-pipelines bot Aug 21, 2025
@dotnet dotnet deleted a comment from PureWeen Aug 21, 2025
@dotnet dotnet deleted a comment from azure-pipelines bot Aug 21, 2025
@dotnet dotnet deleted a comment from PureWeen Aug 21, 2025
@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

  • failing tests unrelated

@PureWeen PureWeen merged commit 2e9707c into dotnet:net10.0 Aug 22, 2025
142 of 148 checks passed
@github-project-automation github-project-automation bot moved this from Changes Requested to Done in MAUI SDK Ongoing Aug 22, 2025
@PureWeen PureWeen modified the milestones: .NET 10.0-rc1, .NET 10.0-rc2 Aug 22, 2025
PureWeen added a commit that referenced this pull request Aug 22, 2025
@PureWeen
Revert "Enhance maui-mobile developer sample with recent updates (#31151
3a03582 
)"

This reverts commit 2e9707c.
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@PureWeen PureWeen PureWeen requested changes

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho was automatically assigned from dotnet/dotnet-maui-reviewers

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz jsuarezruiz was automatically assigned from dotnet/dotnet-maui-reviewers

@jfversluis jfversluis Awaiting requested review from jfversluis

+1 more reviewer

@MartyIX MartyIX MartyIX left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jfversluis jfversluis

Labels

area-templates Project templates, Item Templates for Blazor and MAUI community ✨ Community Contribution p/0 Work that we can't release without partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

MAUI SDK Ongoing
Status: Done

Milestone

.NET 10.0-rc2

Development

Successfully merging this pull request may close these issues.

6 participants

@SuthiYuvaraj @jfversluis @rmarinho @PureWeen @MartyIX @sheiksyedm