[Windows] Fix ImageHandler Vertical&Horizontal Options with AspectFit

[morning4coffe-dev]

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

This pull request addresses a bug where images on WinUI did not respect VerticalOptions and HorizontalOptions when using the AspectFit property. The changes include adding a regression test, updating the ImageHandler to handle layout constraints properly.

This change in behavior streamlines it with other targets, where images with those properties are displayed at the size of the source image. It can then be resized to a smaller size after the source size is met with the size of the panel/window.

Current behavior

Issues Fixed

Fixes #30403

[dotnet-policy-service]

Hey there @@morning4coffe-dev! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[PureWeen]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[Copilot]

Pull Request Overview

This PR fixes a bug where images on WinUI did not respect VerticalOptions and HorizontalOptions when using the AspectFit property. The fix ensures that images with AspectFit are displayed at their source image size and can be properly positioned according to layout options.

• Overrides GetDesiredSize method in ImageHandler.Windows.cs to handle AspectFit layout constraints
• Adds helper method to retrieve actual image dimensions from BitmapSource
• Includes regression test to validate the fix

Reviewed Changes

Copilot reviewed 4 out of 15 changed files in this pull request and generated 3 comments.

File	Description
src/Core/src/Handlers/Image/ImageHandler.Windows.cs	Implements the core fix by overriding GetDesiredSize and adding image size detection
src/Core/src/PublicAPI/net-windows/PublicAPI.Unshipped.txt	Documents the new public API surface for the GetDesiredSize override
src/Controls/tests/TestCases.HostApp/Issues/Issue30403.cs	Creates UI test page demonstrating the image positioning behavior
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue30403.cs	Implements automated test to verify the fix works correctly

[PureWeen]

The images you've modified are all being modified to closer match the other platforms which is awesome!

Can you rebase this one to net10.0 ? Now that we're getting closer to NET10.0 GA changes like this are better to have their so the cheese isn't moving in net9 at this point.

[PureWeen]

/rebase

[PureWeen]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

The tests NoScrollbarsTest and ShadowsDontRespectControlShape are failing on Windows with slightly differences in images.

Example:

Could you review it?

[morning4coffe-dev]

Thanks, @jsuarezruiz! As discussed during our 1:1, I reuploaded the screenshots

[jsuarezruiz]

With the latest modifications, the fix looks good to me. Just requested to expand the added test to cover edge cases where potentially the changes could have an impact.

[jsuarezruiz]

Could modify a little bit this test? Could you include a StackLayout with 2-3 images?
Leave the current one, but could also validate:

• Image with extreme aspect ratio
• Really small image

[jsuarezruiz]

Created a separate issue to create the tests #31686