Skip to content

Fix Stepper control fails to reach maximum value when increment exceeds remaining threshold #29763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2025

Conversation

SuthiYuvaraj
Copy link
Contributor

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Description:

On the Windows platform, the stepper control does not update to the defined maximum value if the increment step is larger than the remaining threshold to reach that maximum.

RootCause:

On the Windows platform, the MauiStepper native control uses a method called UpdateValue, which stops updating the value if it tries to go beyond the defined minimum or maximum limits.
However, on other platforms, the value is updated directly through the Value property, regardless of the min/max limits. The actual limit enforcement happens later through coerceValue logic.

Description of Change:

In order to achieve same behavior, we should directly set the value and rely on CoerceValue to enforce the min/max boundaries.

Issues Fixed

Fixes #29740

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Output Screenshot

Before Issue Fix After Issue Fix
StepperBefore.mov
StepperAfter.mov

@SuthiYuvaraj SuthiYuvaraj changed the title Fix 29740 Fix Stepper control fails to reach maximum value when increment exceeds remaining threshold Jun 2, 2025
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jun 2, 2025
Copy link
Contributor

Hey there @@SuthiYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jun 2, 2025
@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SuthiYuvaraj SuthiYuvaraj marked this pull request as ready for review June 2, 2025 08:02
@SuthiYuvaraj SuthiYuvaraj requested a review from a team as a code owner June 2, 2025 08:02
@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@bhavanesh2001 bhavanesh2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfversluis jfversluis added this to the .NET 9 SR11 milestone Aug 7, 2025
@PureWeen PureWeen changed the base branch from main to inflight/current August 7, 2025 20:59
@PureWeen PureWeen merged commit a3b29d3 into dotnet:inflight/current Aug 7, 2025
76 of 78 checks passed
PureWeen pushed a commit that referenced this pull request Aug 8, 2025
…ds remaining threshold (#29763)

* Fix for 29740

* Update Issue29740.cs

* Update src/Controls/tests/TestCases.HostApp/Issues/Issue29740.cs

indentation changes

Co-authored-by: MartyIX <[email protected]>

* Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29740.cs

Co-authored-by: MartyIX <[email protected]>

---------

Co-authored-by: MartyIX <[email protected]>
github-actions bot pushed a commit that referenced this pull request Aug 11, 2025
…ds remaining threshold (#29763)

* Fix for 29740

* Update Issue29740.cs

* Update src/Controls/tests/TestCases.HostApp/Issues/Issue29740.cs

indentation changes

Co-authored-by: MartyIX <[email protected]>

* Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29740.cs

Co-authored-by: MartyIX <[email protected]>

---------

Co-authored-by: MartyIX <[email protected]>
github-actions bot pushed a commit that referenced this pull request Aug 15, 2025
…ds remaining threshold (#29763)

* Fix for 29740

* Update Issue29740.cs

* Update src/Controls/tests/TestCases.HostApp/Issues/Issue29740.cs

indentation changes

Co-authored-by: MartyIX <[email protected]>

* Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29740.cs

Co-authored-by: MartyIX <[email protected]>

---------

Co-authored-by: MartyIX <[email protected]>
github-actions bot pushed a commit that referenced this pull request Aug 15, 2025
…ds remaining threshold (#29763)

* Fix for 29740

* Update Issue29740.cs

* Update src/Controls/tests/TestCases.HostApp/Issues/Issue29740.cs

indentation changes

Co-authored-by: MartyIX <[email protected]>

* Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29740.cs

Co-authored-by: MartyIX <[email protected]>

---------

Co-authored-by: MartyIX <[email protected]>
github-actions bot pushed a commit that referenced this pull request Aug 19, 2025
…ds remaining threshold (#29763)

* Fix for 29740

* Update Issue29740.cs

* Update src/Controls/tests/TestCases.HostApp/Issues/Issue29740.cs

indentation changes

Co-authored-by: MartyIX <[email protected]>

* Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29740.cs

Co-authored-by: MartyIX <[email protected]>

---------

Co-authored-by: MartyIX <[email protected]>
github-actions bot pushed a commit that referenced this pull request Aug 22, 2025
…ds remaining threshold (#29763)

* Fix for 29740

* Update Issue29740.cs

* Update src/Controls/tests/TestCases.HostApp/Issues/Issue29740.cs

indentation changes

Co-authored-by: MartyIX <[email protected]>

* Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29740.cs

Co-authored-by: MartyIX <[email protected]>

---------

Co-authored-by: MartyIX <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-stepper Stepper community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] - Stepper control fails to reach maximum value when increment exceeds remaining threshold
6 participants