-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix Stepper control fails to reach maximum value when increment exceeds remaining threshold #29763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @@SuthiYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
MartyIX
reviewed
Jun 2, 2025
MartyIX
reviewed
Jun 2, 2025
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29740.cs
Outdated
Show resolved
Hide resolved
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
indentation changes Co-authored-by: MartyIX <[email protected]>
…740.cs Co-authored-by: MartyIX <[email protected]>
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
bhavanesh2001
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jfversluis
approved these changes
Aug 7, 2025
PureWeen
pushed a commit
that referenced
this pull request
Aug 8, 2025
…ds remaining threshold (#29763) * Fix for 29740 * Update Issue29740.cs * Update src/Controls/tests/TestCases.HostApp/Issues/Issue29740.cs indentation changes Co-authored-by: MartyIX <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29740.cs Co-authored-by: MartyIX <[email protected]> --------- Co-authored-by: MartyIX <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Aug 11, 2025
…ds remaining threshold (#29763) * Fix for 29740 * Update Issue29740.cs * Update src/Controls/tests/TestCases.HostApp/Issues/Issue29740.cs indentation changes Co-authored-by: MartyIX <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29740.cs Co-authored-by: MartyIX <[email protected]> --------- Co-authored-by: MartyIX <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2025
…ds remaining threshold (#29763) * Fix for 29740 * Update Issue29740.cs * Update src/Controls/tests/TestCases.HostApp/Issues/Issue29740.cs indentation changes Co-authored-by: MartyIX <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29740.cs Co-authored-by: MartyIX <[email protected]> --------- Co-authored-by: MartyIX <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2025
…ds remaining threshold (#29763) * Fix for 29740 * Update Issue29740.cs * Update src/Controls/tests/TestCases.HostApp/Issues/Issue29740.cs indentation changes Co-authored-by: MartyIX <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29740.cs Co-authored-by: MartyIX <[email protected]> --------- Co-authored-by: MartyIX <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Aug 19, 2025
…ds remaining threshold (#29763) * Fix for 29740 * Update Issue29740.cs * Update src/Controls/tests/TestCases.HostApp/Issues/Issue29740.cs indentation changes Co-authored-by: MartyIX <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29740.cs Co-authored-by: MartyIX <[email protected]> --------- Co-authored-by: MartyIX <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Aug 22, 2025
…ds remaining threshold (#29763) * Fix for 29740 * Update Issue29740.cs * Update src/Controls/tests/TestCases.HostApp/Issues/Issue29740.cs indentation changes Co-authored-by: MartyIX <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29740.cs Co-authored-by: MartyIX <[email protected]> --------- Co-authored-by: MartyIX <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-controls-stepper
Stepper
community ✨
Community Contribution
partner/syncfusion
Issues / PR's with Syncfusion collaboration
platform/windows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Description:
On the Windows platform, the stepper control does not update to the defined maximum value if the increment step is larger than the remaining threshold to reach that maximum.
RootCause:
On the Windows platform, the MauiStepper native control uses a method called UpdateValue, which stops updating the value if it tries to go beyond the defined minimum or maximum limits.
However, on other platforms, the value is updated directly through the Value property, regardless of the min/max limits. The actual limit enforcement happens later through coerceValue logic.
Description of Change:
In order to achieve same behavior, we should directly set the value and rely on CoerceValue to enforce the min/max boundaries.
Issues Fixed
Fixes #29740
Tested the behaviour in the following platforms
Output Screenshot
StepperBefore.mov
StepperAfter.mov