[iOS] Fixed the Items are not displaying in CarouselView 2 #29397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
community ✨
jsuarezruiz
added
platform/ios
area-controls-collectionview
|
/azp run MAUI-UITests-public |
jsuarezruiz
requested changes
May 8, 2025
| // TODO: Replace CarouselView1 with CarouselView once the issues are resolved. | ||
| var carouselView = new CarouselView1 | ||
|
|
||
| var carouselView = new CarouselView |
There was a problem hiding this comment.
Could be nice to update some of the related Issue7678 tests to verify some snapshots.
There was a problem hiding this comment.
Random colors are used for the border background inside the CarouselView template in the Issue7678 test, so I used a validation test instead of relying on screenshots. @jsuarezruiz
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run MAUI-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Root Cause of the issue
Returning a new size directly in the
GetDesiredSizemethod ofItemsViewHandler2.iOSresults in a native height ofzero, causing the item to be invisible in CarouselView2. (Issue 7678)An exception is caused when attempting to scroll to an index that is out of bounds (i.e., not present in the section), which leads to the issue. (Issue 7678_1)
Description of Change
Override the
GetDesiredSizemethod inCarouselViewHandler2.iOSand call GetDesiredSizeFromHandler, which correctly handles and returns the proper native size.Added a check to validate the index before attempting to scroll. This prevents exceptions caused by trying to scroll to an out-of-bounds item in the carousel view.
Fix Reference
Regressed PR
Issues Fixed
Fixes #29310
Test Case
Reenabled the test case :
Issue7678Reenabled the test case :
Issue7678_1Tested the behaviour in the following platforms
Screenshot
CarouselView2Issue.mov
CarouselView2Fix.mov