Skip to content

[tests] On 9.0.4 theres no build warning for System.Text.Json #29243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

rmarinho
Copy link
Member

Description of Change

Buy moving to 9.0.4 the AOT tests for root all assemblies was failing since theres no build warning for System.Text.Json anymore.

Failing build
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=11478717&view=ms.vss-test-web.build-test-results-tab&runId=128335150&resultId=100004&paneView=debug

@Copilot Copilot AI review requested due to automatic review settings April 29, 2025 09:21
@rmarinho rmarinho requested a review from a team as a code owner April 29, 2025 09:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the expected build warning for System.Text.Json in the AOT tests for root all assemblies, addressing failures seen after the 9.0.4 update.

  • Removed the hard-coded expected warning message configured for System.Text.Json
  • Simplified the expectedNativeAOTWarnings list to an empty list
Comments suppressed due to low confidence (1)

src/TestUtils/src/Microsoft.Maui.IntegrationTests/Utilities/BuildWarningsUtilities.cs:129

  • [nitpick] Consider adding a comment on this line explaining that the expected warning for System.Text.Json has been removed due to the 9.0.4 update, to clarify the change in behavior for future maintainers.
private static readonly List<WarningsPerFile> expectedNativeAOTWarnings = new();

@rmarinho rmarinho changed the title [tests] On 9.0.4 theres no build warning for Syste.Text.Json [tests] On 9.0.4 theres no build warning for System.Text.Json Apr 29, 2025
@rmarinho rmarinho merged commit aa9e93e into main Apr 29, 2025
122 of 129 checks passed
@rmarinho rmarinho deleted the fix-build-warnings branch April 29, 2025 13:26
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants