Skip to content

Changes in Android cake to fix emulator boot issues on Linux #29123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 29, 2025

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Apr 22, 2025

Description of Change

Changes in Android cake to fix emulator boot issues on Linux.

Changes:

  • Use adb keygen to regenerate the keys instead restart the ADB server.
  • Sets $ADB_VENDOR_KEYS before restarting ADB to prevents "unauthorized device" issues by defining the variable before restarting the daemon.
  • Ensures file permissions are correct before pushing keys.
  • Added retry (maximum 3 times) to push the ADB keys to the device.

Also, added more descriptive messages showing what's happening in every step (if something fails, at least detect the step).

@jsuarezruiz jsuarezruiz marked this pull request as ready for review April 23, 2025 12:15
@Copilot Copilot AI review requested due to automatic review settings April 23, 2025 12:15
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner April 23, 2025 12:15
@jsuarezruiz
Copy link
Contributor Author

/azp run

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to resolve Android emulator boot issues on Linux by updating the ADB key handling process.

  • Uses "adb keygen" to generate new ADB keys rather than restarting the ADB server for regeneration.
  • Introduces explicit permission settings, retry logic for key pushing, and improved logging.
  • Adjusts the order of stopping/starting the ADB server and configures the ADB_VENDOR_KEYS environment variable.

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor Author

NOTE: I've triggered a new build to ensure everything pass correctly again.

@rmarinho rmarinho merged commit dc63d66 into main Apr 29, 2025
129 checks passed
@rmarinho rmarinho deleted the fix-android-emu-linux-II branch April 29, 2025 13:26
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants