Skip to content

Conversation

@HarishKumarSF4517
Copy link
Contributor

@HarishKumarSF4517 HarishKumarSF4517 commented Apr 14, 2025

Description

Fix for Issue: On iOS, the CollectionView footer width becomes larger than the screen size when the CollectionView's source is empty.

This issue has already been resolved in the main branch through a combination of the current changes and the actual fix implemented in PR #28610

To resolve this issue in SR5.1, I have now included the necessary changes from the main branch into the SR5 branch. While the main branch commit contains additional file changes, I have included only the relevant modifications required to address this specific issue in CV1.

Reference Commit (from main): 609499c

Before fix:

Screenshot 2025-04-11 at 10 21 41 AM

After fix:

Screenshot 2025-04-11 at 10 19 35 AM

Issues Fixed

Fixes #28580

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Apr 14, 2025
@dotnet-policy-service
Copy link
Contributor

Hey there @@HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Apr 14, 2025
@HarishKumarSF4517 HarishKumarSF4517 marked this pull request as ready for review April 14, 2025 10:36
Copilot AI review requested due to automatic review settings April 14, 2025 10:36
@HarishKumarSF4517 HarishKumarSF4517 requested a review from a team as a code owner April 14, 2025 10:36
@HarishKumarSF4517 HarishKumarSF4517 requested review from StephaneDelcroix and jfversluis and removed request for a team April 14, 2025 10:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@PureWeen PureWeen mentioned this pull request Apr 14, 2025
@PureWeen
Copy link
Member

running tests here #28976

@PureWeen PureWeen added this to the .NET 9 SR5.1 milestone Apr 14, 2025
@PureWeen PureWeen added the p/0 Current heighest priority issues that we are targeting for a release. label Apr 14, 2025
@jsuarezruiz jsuarezruiz added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Apr 14, 2025
@PureWeen PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Apr 16, 2025
@rmarinho
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@rmarinho
Copy link
Member

/azp run MAUI-public

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@github-project-automation github-project-automation bot moved this from Ready To Review to Approved in MAUI SDK Ongoing Apr 16, 2025
@PureWeen PureWeen merged commit e1f746f into dotnet:release/9.0.1xx-sr5 Apr 16, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Apr 16, 2025
PureWeen added a commit that referenced this pull request Apr 18, 2025
* Revert "[iOS] CollectionView footer sizing when source is empty in SR5 (#28971)"

* - fix header/footer sizing issue

* - add screenshots

* - set to cv1 because behavior currently differs
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution p/0 Current heighest priority issues that we are targeting for a release. partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants