[Windows] Fix for IndicatorView using templated icons not working #28905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
community ✨
…ing ) SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 committed last week
jsuarezruiz
added
area-controls-collectionview
jsuarezruiz
reviewed
Apr 10, 2025
| public void IndicatorViewWithTemplatedIcon() | ||
| { | ||
| App.WaitForElement("descriptionLabel"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Pending snapshots in all platforms.
There was a problem hiding this comment.
@jsuarezruiz , I've attached the screenshots for the Android and iOS platforms. I will add the screenshots for the other platforms in the next CI run.
SyedAbdulAzeemSF4852
force-pushed
the
fix-7144
branch
2 times, most recently
from
434dece to
3ae6618
Compare
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
rmarinho
previously approved these changes
Apr 15, 2025
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Apr 15, 2025
| @@ -36,8 +36,10 @@ public void SetIndicatorView(IIndicatorView indicatorView) | |||
|
|
|||
| internal void UpdateIndicatorsColor() | |||
| { | |||
| if (_indicatorView == null) | |||
| if (_indicatorView is null || (_indicatorView is ITemplatedIndicatorView templatedView && templatedView.IndicatorsLayoutOverride is not null)) | |||
There was a problem hiding this comment.
This condition is repeated 2 times, can create an internal property like:
internal bool UseShapeIndicator =>
_indicatorView == null ||
(_indicatorView is ITemplatedIndicatorView templatedView && templatedView.IndicatorsLayoutOverride != null);
if (UseShapeIndicator)
{
}
There was a problem hiding this comment.
@jsuarezruiz , Thanks for the suggestion! I've updated the code to use an internal property as you recommended.
rmarinho
approved these changes
Apr 21, 2025
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
pushed a commit
that referenced
this pull request
Apr 23, 2025
…8905) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 committed last week * Have added snapshots for iOS and Android * Have added the snapshots * [Windows] Fix for 7144 ( IndicatorView using templated icons not working )
github-actions bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
…8905) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 committed last week * Have added snapshots for iOS and Android * Have added the snapshots * [Windows] Fix for 7144 ( IndicatorView using templated icons not working )
anandhan-rajagopal
pushed a commit
to anandhan-rajagopal/maui
that referenced
this pull request
May 2, 2025
…tnet#28905) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 committed last week * Have added snapshots for iOS and Android * Have added the snapshots * [Windows] Fix for 7144 ( IndicatorView using templated icons not working )
anandhan-rajagopal
pushed a commit
to anandhan-rajagopal/maui
that referenced
this pull request
May 2, 2025
…tnet#28905) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 committed last week * Have added snapshots for iOS and Android * Have added the snapshots * [Windows] Fix for 7144 ( IndicatorView using templated icons not working )
PureWeen
pushed a commit
that referenced
this pull request
May 2, 2025
…8905) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 committed last week * Have added snapshots for iOS and Android * Have added the snapshots * [Windows] Fix for 7144 ( IndicatorView using templated icons not working )
SuthiYuvaraj
pushed a commit
to SuthiYuvaraj/maui
that referenced
this pull request
May 9, 2025
…tnet#28905) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 committed last week * Have added snapshots for iOS and Android * Have added the snapshots * [Windows] Fix for 7144 ( IndicatorView using templated icons not working )
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
Root Cause
Description
Validated the behaviour in the following platforms
Issues Fixed
Fixes #7144
Output