-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Cleanup virtual layer measure invalidation #28756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup virtual layer measure invalidation #28756
Conversation
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
I wonder what the impact of the PR is in terms of performance. Did you happen to measure the impact, please? |
I think there's a slight performance improve, these are two examples. Android: iOS: (other kind of test) Consider that the app switch I've inserted could make this even better. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Failing tests are not related. |
)" (dotnet#28872)" This reverts commit 4ff875a.
Description of Change
Now that we have merged #28225, and soon will merge #28670, we can finally start getting rid of
MeasureInvalidated
event and also enhance some features.Compatibility.Layout
useless and harming code (causing additional unneeded invalidations/arranges)ComputeConstraintForView
fromCompatibility.Layout
toVisualElement
so new layouts will be able to use it out of the box so that we can leverage Stop iOS SetNeedsLayout propagation by looking at VisualElement computed Constraint #28479MeasureInvalidated
total propagation, basically "revert"s MakeMeasureInvalidated
event work correctly #23052 and goes back to 8.0.82 behavior where the propagation was happening only while using legacy layoutsIssues Fixed
Fixes #25264