[Android] Fix for SearchHandler Placeholder did not update when changed at runtime #28636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue where the SearchHandler's placeholder text was not updating at runtime on Android. Key changes include:
- Adding a new test case in TestCases.Shared.Tests to verify the SearchHandler placeholder update.
- Adding a corresponding UI test case in TestCases.HostApp.
- Updating the Android SearchHandlerAppearanceTracker to handle changes in the Placeholder property.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/TestCases.Shared.Tests/Tests/Issues/Issue28634.cs | Added unit tests for SearchHandler placeholder update |
| tests/TestCases.HostApp/Issues/Issue28634.cs | Added UI test page for triggering the SearchHandler placeholder change |
| src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs | Updated to invoke UpdatePlaceholder when the Placeholder property changes |
jfversluis
previously approved these changes
Mar 26, 2025
jsuarezruiz
added
platform/android
area-controls-shell
jsuarezruiz
reviewed
Mar 26, 2025
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 8, 2025
…ed at runtime (#28636) * Placeholder issue fix * Added Android snapshot * Added Mac and Windows snapshots
bhavanesh2001
pushed a commit
to bhavanesh2001/maui
that referenced
this pull request
Apr 11, 2025
…ed at runtime (dotnet#28636) * Placeholder issue fix * Added Android snapshot * Added Mac and Windows snapshots
PureWeen
pushed a commit
that referenced
this pull request
Apr 11, 2025
…ed at runtime (#28636) * Placeholder issue fix * Added Android snapshot * Added Mac and Windows snapshots
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2025
…ed at runtime (#28636) * Placeholder issue fix * Added Android snapshot * Added Mac and Windows snapshots
github-actions bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
…ed at runtime (#28636) * Placeholder issue fix * Added Android snapshot * Added Mac and Windows snapshots
github-actions bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
…ed at runtime (#28636) * Placeholder issue fix * Added Android snapshot * Added Mac and Windows snapshots
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause of the issue
Description of Change
Issues Fixed
Fixes #28634
Tested the behaviour in the following platforms
Screenshot
Before-fix.mov
After-fix.mov