CollectionView display is broken when setting IsVisible after items are added - Fix #28425
Conversation
kubaflo
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| [Test] | ||
| [Category(UITestCategories.IsVisible)] | ||
| [Category(UITestCategories.CollectionView)] | ||
| public void CollectionViewItemsShouldBeVisible() |
There was a problem hiding this comment.
The test is failing on Windows:
The app was expected to be running still, investigate as possible crash
Seems is crashing.
There was a problem hiding this comment.
Could you please /azp again?
jsuarezruiz
added
the
area-controls-collectionview
| @@ -591,18 +591,6 @@ private protected virtual void InvalidateMeasureLegacy(InvalidationTrigger trigg | |||
| } | |||
| } | |||
|
|
|||
| internal override void OnIsVisibleChanged(bool oldValue, bool newValue) | |||
There was a problem hiding this comment.
do we have tests related to this ?
There was a problem hiding this comment.
I'm not sure about it. I hoped that the current uI tests would be enough to catch a potential regression
Ther are passing locally so these seem to still be flaky #27905 |
|
It has been many moons, but is this PR still needed? the issue #28415 is closed now. |
Description of Change
I think that because of this PR #20154 this override of
OnIsVisibleChangedcan be removed, which would improve the performance ofCompatibility.LayoutIssues Fixed
Fixes #28415