Skip to content

Fix Issue13551 to use WaitForElement #27644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2025
Merged

Fix Issue13551 to use WaitForElement #27644

merged 1 commit into from
Feb 9, 2025

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Feb 7, 2025

Description of Change

When this test was copied over it incorrectly used WaitForNoElement instead of WaitForElement.

If you look at the original test here you can see it should be WaitForNoElement.

The reason it's been passing occasionally is that the WaitForNoElement call was returning sometimes before the page even loaded so the test would finish running before it even had time to load.

@Copilot Copilot AI review requested due to automatic review settings February 7, 2025 22:33
@PureWeen PureWeen requested a review from a team as a code owner February 7, 2025 22:33
Copilot
Copilot AI reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@PureWeen PureWeen merged commit a4f0176 into main Feb 9, 2025
120 of 123 checks passed
@PureWeen PureWeen deleted the fix-Issue13551 branch February 9, 2025 13:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PureWeen