Fix iOS ScrollView content being measured with non-infinite constraints during LayoutSubviews pass #27298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
4 tasks
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/backport to release/9.0.1xx-sr3 |
|
Started backporting to release/9.0.1xx-sr3: https://github.com/dotnet/maui/actions/runs/12937847968 |
PureWeen
approved these changes
Jan 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
With #26763 we removed the middle layer (a
MauiView) which was sitting between theMauiScrollViewand its content.That middle layer was important because it prevented the content to be measured with
Boundsduring theLayoutSubviewspass.This PR simply excludes the cross platform measure pass when the parent is
MauiScrollView(same thing happening withMauiView).In fact, now
MauiScrollViewcan be considered a cross platform layout.The UI test covers all platforms, so this should be helpful in verifying we have the same behavior in case we refactor also other platforms.
Issues Fixed
Fixes #27169