-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Testing] Enabling WebView UITests from Issues folder in Appium #27284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Enabling WebView UITests from Issues folder in Appium #27284
Conversation
Hey there @NafeelaNazhir! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Azure Pipelines successfully started running 3 pipeline(s). |
// Element not found within timeout, assume internet is available | ||
// Continue with the test | ||
} | ||
VerifyInternetConnectivity(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jsuarezruiz, The previous approach of checking internet connectivity using Connectivity.Current.InternetAccess has limitations, as it only verifies the internet status on the emulator. If the connected device lacks internet access, the test case still executes, leading to false results. Modified the way of checking internet connection by referring to the Xamarin implementation. Kindly review and share your concerns
References:
MAUI Networking Documentation
Previous MAUI Implementation
Xamarin Reference
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the latest set of changes I'm still seeing the webview ones failing
Azure Pipelines successfully started running 3 pipeline(s). |
Hi @PureWeen, Addressed the test failures on CI failures and committed the code changes, could you please review and share your concerns. |
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
Azure Pipelines successfully started running 3 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 3 pipeline(s). |
Description of Change
This PR focuses on enabling and updating 11 testcases in Appium. The tests, previously ignored using Fails attribute, are reviewed, and modified to ensure they are functional with the Appium framework. We are going to enable tests in blocks in different PRs.
TestCases: