Skip to content

Conversation

NafeelaNazhir
Copy link
Contributor

@NafeelaNazhir NafeelaNazhir commented Jan 22, 2025

Description of Change

This PR focuses on enabling and updating 11 testcases in Appium. The tests, previously ignored using Fails attribute, are reviewed, and modified to ensure they are functional with the Appium framework. We are going to enable tests in blocks in different PRs.

TestCases:

  • Bugzilla35733
  • Issue10744
  • Issue12134
  • Issue16032
  • Issue18452
  • Issue21631
  • Issue21846
  • MemoryTests
  • Issue4720
  • Issue6286
  • Issue6323

@NafeelaNazhir NafeelaNazhir added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 22, 2025
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 22, 2025
Copy link
Contributor

Hey there @NafeelaNazhir! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@NafeelaNazhir NafeelaNazhir added area-testing Unit tests, device tests and removed community ✨ Community Contribution labels Jan 22, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@NafeelaNazhir NafeelaNazhir changed the title [Testing] Enabling some UITests from Issues folder in Appium [Testing] Enabling WebView UITests from Issues folder in Appium Jan 23, 2025
@NafeelaNazhir NafeelaNazhir marked this pull request as ready for review January 23, 2025 04:24
@Copilot Copilot AI review requested due to automatic review settings January 23, 2025 04:24
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

// Element not found within timeout, assume internet is available
// Continue with the test
}
VerifyInternetConnectivity();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several WebView tests failing on Android:

image

The app was expected to be running still, investigate as possible crash

Potentially, crashing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsuarezruiz, The previous approach of checking internet connectivity using Connectivity.Current.InternetAccess has limitations, as it only verifies the internet status on the emulator. If the connected device lacks internet access, the test case still executes, leading to false results. Modified the way of checking internet connection by referring to the Xamarin implementation. Kindly review and share your concerns

References:

MAUI Networking Documentation
Previous MAUI Implementation
Xamarin Reference

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Feb 6, 2025

/azp run

This comment was marked as off-topic.

@PureWeen PureWeen added this to the .NET 9 SR4 milestone Feb 7, 2025
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@NafeelaNazhir
Copy link
Contributor Author

On the latest set of changes I'm still seeing the webview ones failing

https://dev.azure.com/xamarin/public/_build/results?buildId=134534&view=ms.vss-test-web.build-test-results-tab&runId=3720567&resultId=100019&paneView=debug

Hi @PureWeen, Addressed the test failures on CI failures and committed the code changes, could you please review and share your concerns.

@PureWeen PureWeen modified the milestones: .NET 9 SR4, .NET 9 SR5 Feb 10, 2025
@PureWeen
Copy link
Member

PureWeen commented Feb 10, 2025

/azp run

This comment was marked as outdated.

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen dismissed their stale review February 13, 2025 13:17

Changes made

@PureWeen PureWeen merged commit 29372c5 into dotnet:main Feb 13, 2025
129 of 132 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants