Skip to content

[Testing] Implement ContextMenu UITest extension methods #26204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 7, 2025

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Implement ContextMenu UITest extension methods.

Example:
App.ActivateContextMenu("Cell");

Enabling the following tests:

  • Bugzilla58875Test
  • ContextActionsIconImageSource
  • RaisingCommandCanExecuteChangedCausesCrashOnAndroid

@jsuarezruiz jsuarezruiz added the area-testing Unit tests, device tests label Nov 28, 2024
@jsuarezruiz
Copy link
Contributor Author

Rebased and passed added test locally:
image

@jsuarezruiz jsuarezruiz marked this pull request as ready for review January 29, 2025 08:02
@Copilot Copilot AI review requested due to automatic review settings January 29, 2025 08:02
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner January 29, 2025 08:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 12 changed files in this pull request and generated 2 comments.

Files not reviewed (6)
  • src/TestUtils/src/UITest.Appium/AppiumIOSApp.cs: Evaluated as low risk
  • src/TestUtils/src/UITest.Appium/AppiumWindowsApp.cs: Evaluated as low risk
  • src/TestUtils/src/UITest.Appium/HelperExtensions.cs: Evaluated as low risk
  • src/TestUtils/src/UITest.Appium/AppiumAndroidApp.cs: Evaluated as low risk
  • src/TestUtils/src/UITest.Appium/AppiumCatalystApp.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/Issue6258.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)

src/TestUtils/src/UITest.Appium/Actions/AppiumAndroidContextMenuActions.cs:54

  • [nitpick] Ensure that the timing values for the pointer move actions are reliable across different devices or scenarios. Consider making these values configurable or documenting their usage.
longPress.AddAction(touchDevice.CreatePointerMove(appiumElement, 0, 0, TimeSpan.FromMilliseconds(5)));

src/TestUtils/src/UITest.Appium/Actions/AppiumAndroidContextMenuActions.cs:56

  • [nitpick] Ensure that the timing values for the pointer move actions are reliable across different devices or scenarios. Consider making these values configurable or documenting their usage.
longPress.AddAction(touchDevice.CreatePointerMove(appiumElement, 0, 0, TimeSpan.FromMilliseconds(2000)));

@jfversluis jfversluis merged commit 9c3cb1a into main Feb 7, 2025
124 checks passed
@jfversluis jfversluis deleted the uitest-contextmenu-actions-II branch February 7, 2025 12:07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants