Skip to content

Conversation

NanthiniMahalingam
Copy link
Contributor

Issue Details

  • When selecting the last page in a TabbedPage and leaving the TabbedPage using the PopModalAsync method to navigate to the main page, reloading the TabbedPage with a new instance causes the selected indicator to not update properly.

Root cause

  • The NavigationView's selected item is not set to null when leaving the TabbedPage using the PopModalAsync method after selecting a page. As a result, the selected indicator for the previous page is not removed properly.

Description of Change

  • Invoked the OnHandlerDisconnect method when leaving the TabbedPage and set the NavigationView's selected item to null.

Validated the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Fixes #26069

Output

Before After
Before_fix.mp4
After_fix.mp4

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 28, 2024
Copy link
Contributor

Hey there @NanthiniMahalingam! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@NanthiniMahalingam NanthiniMahalingam changed the title Fix 26069 Fixed [Windows] TabbedPage current page indicator can be wrong Nov 28, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@NanthiniMahalingam NanthiniMahalingam marked this pull request as ready for review November 29, 2024 06:30
@NanthiniMahalingam NanthiniMahalingam requested a review from a team as a code owner November 29, 2024 06:30
@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Nov 29, 2024

/azp run

This comment was marked as off-topic.

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen added this to the .NET 9 SR3 milestone Dec 6, 2024
@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 6, 2024
@PureWeen PureWeen merged commit 720226d into dotnet:main Jan 8, 2025
104 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-tabbedpage TabbedPage community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] TabbedPage current page indicator can be wrong.
5 participants