25421- ListViewRenderer Crash in HostApp and BindingError was occured in windows platforms #25453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishnumenon2684
requested review from
Eilon and
tj-devel709
and removed request for
a team
|
@dotnet-policy-service agree |
Foda
approved these changes
Oct 22, 2024
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
jsuarezruiz
approved these changes
Oct 23, 2024
|
/rebase |
github-actions
bot
force-pushed
the
Fix-25421
branch
from
e6768c1 to
6e62355
Compare
|
/rebase |
1 similar comment
|
/rebase |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
sheiksyedm
added
the
partner/syncfusion
samhouts
added
the
fixed-in-net8.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RootCause
ListViewRenderer Crash on HostApp
As the HostApp uses a ListView to display a list of items, selecting a page navigates to the corresponding test cases and sets the sample page as the current main page. This action disposes the HostApp's main page, which contains the ListView. As a result, the previous list is also disposed, leading to a crash in the ListViewRenderer during the
OnControlSelectionChangedevent.BindingErrors occurs on windows platform
In the HostApp, the pages private field of the ListView is set as the BindingContext of the ListView, which is causing the issue. The pages field is directly assigned to the
ItemsSource, so there's no need to set theBindingContext. The problem arises because the same collection is being used for both theBindingContextand theItemsSource, which is the root cause of the issue.Description of Change
ListViewRenderer Crash on HostApp
The ListView events are unwired, and resources are cleaned up in the
DisconnectHandlerCoremethod of the ListView renderer, ensuring all events are properly disconnected.BindingErrors occurs on windows platform
There is no need to define the BindingContext.
Issues Fixed
Fixes #25421