Skip to content

[nuget-msi-convert] Do not use new VS component IDs #25355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

pjcollins
Copy link
Member

Context: ce01c15

We've decided hold off on this change until .NET 10.

@pjcollins pjcollins requested a review from a team as a code owner October 17, 2024 19:37
@pjcollins
Copy link
Member Author

@rmarinho we'll need this in all .NET 9 branches where this prop was added and set to true.

@PureWeen PureWeen changed the base branch from net9.0 to release/9.0.1xx October 17, 2024 21:03
@PureWeen PureWeen requested a review from a team as a code owner October 17, 2024 21:03
@PureWeen PureWeen force-pushed the dev/pjc/revert-new-vsids branch from 5314054 to feaf17e Compare October 17, 2024 21:11
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@PureWeen
Copy link
Member

/rebase

Context: ce01c15

We've decided hold off on this change until .NET 10.
@github-actions github-actions bot force-pushed the dev/pjc/revert-new-vsids branch from feaf17e to 1eca4e3 Compare October 18, 2024 13:06
@PureWeen
Copy link
Member

  • Failing tests are unrelated

@PureWeen PureWeen merged commit f5ca66a into release/9.0.1xx Oct 18, 2024
5 of 7 checks passed
@PureWeen PureWeen deleted the dev/pjc/revert-new-vsids branch October 18, 2024 20:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants