Make ampersands work *more* in net9-only blazor-solution template #23589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
area-blazor
Fixes #23105 (Note: This isn't a complete fix because there seem to be issues in other parts of the product. They are tracked separately via dotnet/aspnetcore#56765).
Eilon
force-pushed
the
eilon/net9andampersand
branch
from
242e10f to
da76906
Compare
Eilon
commented
Jul 13, 2024
src/TestUtils/src/Microsoft.Maui.IntegrationTests/TemplateTests.cs
Outdated
Show resolved
Hide resolved
rmarinho
pushed a commit
that referenced
this pull request
Jul 15, 2024
rmarinho
approved these changes
Jul 15, 2024
samhouts
added
the
fixed-in-net9.0-nightly
samhouts
added
the
fixed-in-net8.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23105
This change is effectivly applying the same change as #22084, but to the net9-only template in the net9 branch.
However, unfortunately this doesn't seem like it can be a complete fix because there seem to be issues in other parts of the product. They are tracked separately in these issues:
&(ampersand) or&(ampersand) in it during AOT phase android#9107 (this bug means that Android won't work at all with&in the path, but the other platforms seem to work).This fix does address some cases, though, and helps ensure that at least the code generated by the templates is valid, even if other parts of the system are incapable of processing certain characters.