[ios/catalyst] avoid duplicating UIView.Subviews arrays
#21765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: #21580 Similar to: #21308 Recording this app in `dotnet-trace`, I saw: (0.81%) Microsoft.MacCatalyst!UIKit.UIView.get_Subviews() Where this time is spent in: * `Microsoft.Maui!Microsoft.Maui.Platform.WrapperView` Reviewing the code, it calls `this.Subviews` twice, which would marshal and create two arrays. It then calls `Subviews[0]`. Storing in a local instead will avoid creating the array twice: var subviews = Subviews; if (subviews.Length == 0) return; //... var child = subviews[0]; This improves things a small amount, but is probably worth it: (0.72%) Microsoft.MacCatalyst!UIKit.UIView.get_Subviews() I'll think about making an analyzer for this, but I didn't find any similar cases that appear in `dotnet-trace` at the moment. This doesn't fully solve #21580, but it's a small improvement.
jonathanpeppers
requested review from
jfversluis and
PureWeen
and removed request for
a team
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
rmarinho
approved these changes
Apr 11, 2024
|
I just realized when I tested this -- I wasn't using my local build of MAUI! This might help slightly more than I originally thought: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #21580
Similar to: #21308
Recording this app in
dotnet-trace, I saw:Where this time is spent in:
Microsoft.Maui!Microsoft.Maui.Platform.WrapperViewReviewing the code, it calls
this.Subviewstwice, which would marshal and create two arrays. It then callsSubviews[0].Storing in a local instead will avoid creating the array twice:
This improves things a small amount, but is probably worth it:
I'll think about making an analyzer for this, but I didn't find any similar cases that appear in
dotnet-traceat the moment.This doesn't fully solve #21580, but it's a small improvement.