[android] improve FormattedString performance #21712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://github.com/Redth/MauiCollectionViewGallery Fixes: #14222 This will conflict with: * #20352 But I will rework this after it is merged. Profiling the above sample while scrolling on a Pixel 5, a lot of time is spent in `FormattedStringExtensions.RecalculateSpanPositions()`: (20%) Microsoft.Maui.Controls!Microsoft.Maui.Controls.Platform.FormattedStringExtensions.RecalculateSpanPositions(Android.Widget.TextView,Microsoft.Maui.Controls.Label,Android.Text.SpannableString,Microsoft.Maui.SizeRequest) (11%) Microsoft.Maui.Controls!Microsoft.Maui.Controls.Platform.FormattedStringExtensions.FontSpan.UpdateDrawState(Android.Text.TextPaint) (11%) Microsoft.Maui.Controls!Microsoft.Maui.Controls.Platform.FormattedStringExtensions.FontSpan.Apply(Android.Text.TextPaint) (6.3%) MauiCollectionViewGallery!PoolMathApp.Helpers.FormattedTextExtensions.ToFormattedString(PoolMathApp.Models.FormattedTex The key contributors are `FontSpan` and `LineHeightSpan` which: * Implement `MetricAffectingSpan`, an abstract class that allows to change the metrics of the text. * Implement `UpdateDrawState()` and `Apply()` methods that are called during draw. Causing frequent Java -> C# interop. To fix this, let's move the following types from C# to Java: * `FontSpan` -> `PlatformFontSpan` * `LetterSpacingSpan` -> `PlatformFontSpan` (use different ctor) * `LineHeightSpan` -> `PlatformLineHeightSpan` `PlatformLineHeightSpan` is similar, as it is an implementation of the `LineHeightSpan` interface. With these changes, I see a nice improvement while scrolling: (5.5%) Microsoft.Maui.Controls!Microsoft.Maui.Controls.Platform.FormattedStringExtensions.RecalculateSpanPositions(Android.Widget.TextView,Microsoft.Maui.Controls.Label,Android.Text.SpannableString,Microsoft.Maui.SizeRequest) (4.0%) MauiCollectionViewGallery!PoolMathApp.Helpers.FormattedTextExtensions.ToFormattedString(PoolMathApp.Models.FormattedText `RecalculateSpanPositions` overall, went from 20% to 5.5%! Comparing the new types, the times spent calling the constructors are also improved: Before: (1.1%) Microsoft.Maui.Controls!Microsoft.Maui.Controls.Platform.FormattedStringExtensions.FontSpan..ctor(Microsoft.Maui.Font,M (1.5%) Microsoft.Maui.Controls!Microsoft.Maui.Controls.Platform.FormattedStringExtensions.LetterSpacingSpan..ctor(double) After: (1.0%) Microsoft.Maui!Microsoft.Maui.PlatformFontSpan..ctor(Android.Content.Context,Android.Graphics.Typeface,bool,single) (0.82%) Microsoft.Maui!Microsoft.Maui.PlatformFontSpan..ctor(single) This should be reasonable for .NET 8servicing, as there should be no behavior changes and no API changes. In a future PR, it looks like `FormattedStringExtensions` could be improved further, but this is a decent starting point that makes it a lot better.
jonathanpeppers
requested review from
jsuarezruiz and
tj-devel709
and removed request for
a team
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
jsuarezruiz
added
platform/android
legacy-area-perf
dotnet-policy-service
bot
added
the
legacy-area-controls
jsuarezruiz
approved these changes
Apr 9, 2024
|
/azp run MAUI-UITests-public |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
mattleibow
approved these changes
Apr 9, 2024
mattleibow
reviewed
Apr 9, 2024
|
Seeing an odd exception with MAUI 8.0.21 on Android 13. Not seeing this on Android 14. Seems maybe related to your changes here? |
|
@mfeingol did you already try a rebuild? If I download: I see the file inside:
So you might also check your NuGet cache, to see if something inside is malformed. |
|
@jonathanpeppers: okay, yeah, I had to do some cleanup but now it's working without issues so it was probably a bad build artifact. Sorry for the noise! |
Eilon
added
perf/general
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/Redth/MauiCollectionViewGallery
Fixes #14222
This depends on changes in:
(as both of these would conflict with each other)
Profiling the above sample while scrolling on a Pixel 5, a lot of time is spent in
FormattedStringExtensions.RecalculateSpanPositions():The key contributors are
FontSpanandLineHeightSpanwhich:Implement
MetricAffectingSpan, an abstract class that allows to change the metrics of the text.Implement
UpdateDrawState()andApply()methods that are called during draw. Causing frequent Java -> C# interop.To fix this, let's move the following types from C# to Java:
FontSpan->PlatformFontSpanLetterSpacingSpan->PlatformFontSpan(use different ctor)LineHeightSpan->PlatformLineHeightSpanPlatformLineHeightSpanis similar, as it is an implementation of theLineHeightSpaninterface.With these changes, I see a nice improvement while scrolling:
RecalculateSpanPositionsoverall, went from 20% to 5.5%!Comparing the new types, the times spent calling the constructors are also improved:
This should be reasonable for .NET 8servicing, as there should be no behavior changes and no API changes.
In a future PR, it looks like
FormattedStringExtensionscould be improved further, but this is a decent starting point that makes it a lot better.