Skip to content

Conversation

@jsuarezruiz
Copy link
Contributor

Description of Change

Rework Appium Runner so that it goes directly to tests instead of navigates.

image

Issues Fixed

Fixes #20614

@jsuarezruiz jsuarezruiz marked this pull request as ready for review February 21, 2024 08:46
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner February 21, 2024 08:46
@jsuarezruiz
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

/rebase

@jsuarezruiz
Copy link
Contributor Author

By changing MainPage and resetting after each test, golden tests require updating the reference snapshots. In many cases, the difference is the NavigationBar, back button etc.

@jsuarezruiz
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

PureWeen commented Apr 5, 2024

Maybe instead of the checkbox we can just add an entry? Just trying to reduce the number of things we have to interact with at startup?
I wish we could more easily "reset the app" without having to call "Resetapp" hmmm
It looks like there's a few tests failing as well in CI

We can remove it but, then, we will always reset, right?. With the CheckBox we can mark and decide if we want to reset or not.

For now let's just always reset.

If there are two text boxes then the second text box can always be used to swap the main page
If a test doesn't want to swap the main page then it can use normal navigation

@jsuarezruiz jsuarezruiz requested a review from PureWeen April 5, 2024 17:16
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working through this one a bit.

Just wanted to add a request changes comment here so it's not merged yet.

@jsuarezruiz
Copy link
Contributor Author

Working through this one a bit.

Just wanted to add a request changes comment here so it's not merged yet.

Let me know if you have feedback, request changes etc :)

@PureWeen PureWeen closed this Apr 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Testing] Rework Appium Runner so that it goes directly to tests instead of navigates

3 participants