-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Window] Fix transforms being offset by 0.5x0.5 #20454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add an UITest with the example from the video where a button is pressed, an Ellipse is rotated and after finishing the animation verify the Ellipse position? It can be done easily using the VerifyScreenshot
method. Example:
VerifyScreenshot(); |
And needs rebase too please |
Added! |
/rebase |
0e5beab
to
979256f
Compare
src/Controls/samples/Controls.Sample.UITests/Issues/Issue17694.cs
Outdated
Show resolved
Hide resolved
/rebase |
6f33a89
to
c3f5cf1
Compare
* Fix transforms being offset by 0.5x0.5 * Added visual regression test * Adjust tests * Fix ref image * update baseline img again... --------- Co-authored-by: Mike Corsaro <[email protected]>
Description of Change
This PR fixes rotations being offset by 0.5 px in each direction. The property
CenterX
andCenterY
are not normalized (0.0 - 1.0), therefore, setting them offset the transform. Additionally, we already set theRenderTransformOrigin
a few lines up.Recording.2024-02-08.141241.mp4
Issues Fixed
Fixes #17694