Skip to content

(Windows) ImageButton contents now explicitly stretches #17159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 16, 2024

Conversation

Foda
Copy link
Member

@Foda Foda commented Aug 31, 2023

Description of Change

ImageButton contents now explicitly stretches... which avoids aliasing. For some reason, setting the height and width of the image to NaN causes them to be aliased when downscaled.

Before After
Screenshot 2023-08-31 135621 Screenshot 2023-08-31 135631

Issues Fixed

Fixes #16918

@Foda Foda added platform/windows area-image Image loading, sources, caching legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-controls-button Button, ImageButton labels Aug 31, 2023
@Foda Foda requested a review from a team as a code owner August 31, 2023 21:20
@Foda Foda requested review from PureWeen and jsuarezruiz August 31, 2023 21:20
@samhouts samhouts added this to the Under Consideration milestone Sep 1, 2023
@samhouts samhouts added the stale Indicates a stale issue/pr and will be closed soon label Sep 18, 2023
jsuarezruiz
jsuarezruiz previously approved these changes Sep 28, 2023
@Foda
Copy link
Member Author

Foda commented Oct 26, 2023

/rebase

2 similar comments
@Foda
Copy link
Member Author

Foda commented Nov 16, 2023

/rebase

@Foda
Copy link
Member Author

Foda commented Feb 15, 2024

/rebase

@mattleibow mattleibow merged commit 7dff6eb into main Feb 16, 2024
@mattleibow mattleibow deleted the foda/ImageButtonStretch branch February 16, 2024 15:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@Eilon Eilon removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-image Image loading, sources, caching labels May 10, 2024
@samhouts samhouts removed this from the Under Consideration milestone Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageButton is not properly anti-aliased when scaled down
6 participants