Skip to content

[net10.0] A few minor xml docs updates. #23969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

[net10.0] A few minor xml docs updates. #23969

merged 1 commit into from
Oct 9, 2025

Conversation

rolfbjarne
Copy link
Member

  • Don't use the 'remarks' element for enum fields, they're ignored in the publishing process.
  • Fix the 'inheritdocs' element on CMVideoDimensions, the docs pipeline says it can't be resolved, so just provide explicit docs.
  • Update all the other xml docs for CMVideoDimensions as well.
  • Fix horribly incorrect docs for CGRect.ToString.

@rolfbjarne
[net10.0] A few minor xml docs updates.
0d11680 
* Don't use the 'remarks' element for enum fields, they're ignored in the publishing process.
* Fix the 'inheritdocs' element on CMVideoDimensions, the docs pipeline says it can't be resolved, so just provide explicit docs.
* Update all the other xml docs for CMVideoDimensions as well.
* Fix horribly incorrect docs for CGRect.ToString.
@rolfbjarne rolfbjarne requested a review from dalexsoto as a code owner October 9, 2025 16:58
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #0d11680] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 0d11680e32891ebc9d1aa03638075257b2d18699 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #0d11680] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 0d11680e32891ebc9d1aa03638075257b2d18699 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 0d11680e32891ebc9d1aa03638075257b2d18699 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #0d11680] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 0d11680e32891ebc9d1aa03638075257b2d18699 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0d11680] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 0d11680e32891ebc9d1aa03638075257b2d18699 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0d11680] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 0d11680e32891ebc9d1aa03638075257b2d18699 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0d11680] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 0d11680e32891ebc9d1aa03638075257b2d18699 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0d11680] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 0d11680e32891ebc9d1aa03638075257b2d18699 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0d11680] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 0d11680e32891ebc9d1aa03638075257b2d18699 [PR build]

@rolfbjarne rolfbjarne enabled auto-merge (squash) October 9, 2025 22:38
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #0d11680] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0d11680e32891ebc9d1aa03638075257b2d18699 [PR build]

@rolfbjarne rolfbjarne merged commit 22667ee into net10.0 Oct 9, 2025
45 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/net10.0-docs-udpate branch October 9, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto