Skip to content

[msbuild] Use TaskRunner.CopyInputsAsync2 to copy inputs to the remote build server. #23965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 13, 2025
Merged

[msbuild] Use TaskRunner.CopyInputsAsync2 to copy inputs to the remote build server. #23965

merged 5 commits into from
Oct 13, 2025
+22 −12

Conversation

rolfbjarne
Copy link
Member

This improves error reporting.

A messaging bump is required to get the CopyInputsAsync2 method.

rolfbjarne and others added 4 commits October 7, 2025 16:06
@rolfbjarne
[msbuild] Unify and improve code to execute tasks remotely. Fixes #23927
f4312dd 
.

Add methods to XamarinTask to execute a task remotely, and use these methods everywhere.

Also:

* Show a (new) error if remote execution failed, and an error wasn't already reported.
* Handle an exceptions and show a proper MSBuild error.

This reduces a lot of code duplication, and also improves error handling.

Fixes #23927.
Auto-format source code
edcb914
@rolfbjarne
Merge remote-tracking branch 'origin/main' into dev/rolf/issue-23927-…
a913d85 
…skip-verify-xcode-when-no-remote-mac
@rolfbjarne
[msbuild] Use TaskRunner.CopyInputsAsync2 to copy inputs to the remot…
d00d40e 
…e build server.

This improves error reporting.

A messaging bump is required to get the CopyInputsAsync2 method.
@rolfbjarne rolfbjarne requested review from emaf and mauroa as code owners October 9, 2025 08:11
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
Base automatically changed from dev/rolf/issue-23927-skip-verify-xcode-when-no-remote-mac to main October 13, 2025 08:53
@rolfbjarne rolfbjarne enabled auto-merge (squash) October 13, 2025 08:55
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #873f944] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 873f9440332e91053726c88a19f2f1f4546da3a0 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #873f944] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 873f9440332e91053726c88a19f2f1f4546da3a0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #873f944] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 873f9440332e91053726c88a19f2f1f4546da3a0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #873f944] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 873f9440332e91053726c88a19f2f1f4546da3a0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #873f944] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 873f9440332e91053726c88a19f2f1f4546da3a0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #873f944] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 873f9440332e91053726c88a19f2f1f4546da3a0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #873f944] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 873f9440332e91053726c88a19f2f1f4546da3a0 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #873f944] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 873f9440332e91053726c88a19f2f1f4546da3a0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #873f944] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 124 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 873f9440332e91053726c88a19f2f1f4546da3a0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 873f9440332e91053726c88a19f2f1f4546da3a0 [PR build]

@rolfbjarne rolfbjarne merged commit 568840b into main Oct 13, 2025
45 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/bump-messaging-copyinputsasync2 branch October 13, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@mauroa mauroa mauroa approved these changes

@emaf emaf emaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @mauroa @emaf