[msbuild] Unify and improve code to execute tasks remotely. Fixes #23927. #23944

rolfbjarne · 2025-10-07T14:06:23Z

Add methods to XamarinTask to execute a task remotely, and use these methods everywhere.

Also:

Show a (new) error if remote execution failed, and an error wasn't already reported.
Handle an exceptions and show a proper MSBuild error.

This reduces a lot of code duplication, and also improves error handling.

. Add methods to XamarinTask to execute a task remotely, and use these methods everywhere. Also: * Show a (new) error if remote execution failed, and an error wasn't already reported. * Handle an exceptions and show a proper MSBuild error. This reduces a lot of code duplication, and also improves error handling. Fixes #23927.

…skip-verify-xcode-when-no-remote-mac

vs-mobiletools-engineering-service2 · 2025-10-08T15:54:45Z

✅ [CI Build #a913d85] Build passed (Build packages) ✅

Pipeline on Agent
Hash: a913d853a2592cbd242e952a8ea41be55f66365f [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T15:56:34Z

✅ [PR Build #a913d85] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: a913d853a2592cbd242e952a8ea41be55f66365f [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T16:23:40Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: a913d853a2592cbd242e952a8ea41be55f66365f [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T16:28:14Z

✅ [CI Build #a913d85] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: a913d853a2592cbd242e952a8ea41be55f66365f [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T16:39:29Z

💻 [CI Build #a913d85] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: a913d853a2592cbd242e952a8ea41be55f66365f [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T16:40:15Z

💻 [CI Build #a913d85] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: a913d853a2592cbd242e952a8ea41be55f66365f [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T16:42:01Z

💻 [CI Build #a913d85] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: a913d853a2592cbd242e952a8ea41be55f66365f [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T16:44:21Z

💻 [CI Build #a913d85] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: a913d853a2592cbd242e952a8ea41be55f66365f [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T16:50:19Z

💻 [CI Build #a913d85] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: a913d853a2592cbd242e952a8ea41be55f66365f [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T17:24:08Z

🚀 [CI Build #a913d85] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: a913d853a2592cbd242e952a8ea41be55f66365f [PR build]

emaf · 2025-10-10T14:02:13Z

msbuild/Xamarin.MacDev.Tasks/Tasks/PrepareNativeReferences.cs

-			var taskRunner = new TaskRunner (SessionId, BuildEngine4);
+			var success = base.ExecuteRemotely (out var taskRunner);

-			try {


Should we keep the try/catch around the GetFileAsync call?

rolfbjarne and others added 2 commits October 7, 2025 16:06

Auto-format source code

edcb914

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into dev/rolf/issue-23927-…

a913d85

…skip-verify-xcode-when-no-remote-mac

rolfbjarne marked this pull request as ready for review October 8, 2025 15:24

rolfbjarne requested review from emaf and mauroa as code owners October 8, 2025 15:24

dalexsoto approved these changes Oct 9, 2025

View reviewed changes

mauroa approved these changes Oct 10, 2025

View reviewed changes

emaf reviewed Oct 10, 2025

View reviewed changes

emaf approved these changes Oct 10, 2025

View reviewed changes

rolfbjarne merged commit 9c1feae into main Oct 13, 2025
45 checks passed

rolfbjarne deleted the dev/rolf/issue-23927-skip-verify-xcode-when-no-remote-mac branch October 13, 2025 08:53

[msbuild] Unify and improve code to execute tasks remotely. Fixes #23927. #23944

[msbuild] Unify and improve code to execute tasks remotely. Fixes #23927. #23944

Uh oh!

Conversation

rolfbjarne commented Oct 7, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 8, 2025

✅ [CI Build #a913d85] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

✅ [PR Build #a913d85] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

✅ [CI Build #a913d85] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

💻 [CI Build #a913d85] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

💻 [CI Build #a913d85] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

💻 [CI Build #a913d85] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

💻 [CI Build #a913d85] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

💻 [CI Build #a913d85] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

🚀 [CI Build #a913d85] Test results 🚀

Test results

Tests counts

Uh oh!

emaf Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants