Skip to content

Use 'EnableDiagnostics' instead of 'EnableProfiler'. #22982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

Use 'EnableDiagnostics' instead of 'EnableProfiler'. #22982

merged 1 commit into from
Jun 3, 2025

Conversation

rolfbjarne
Copy link
Member

Ref: dotnet/runtime#115473 (comment)

Android will do the same.

@rolfbjarne rolfbjarne requested review from emaf and mauroa as code owners June 3, 2025 08:44
rolfbjarne added a commit that referenced this pull request Jun 3, 2025
@rolfbjarne
[release/9.0.1xx] Use 'EnableDiagnostics' instead of 'EnableProfiler'.
ef2e7ae 
Ref: dotnet/runtime#115473 (comment)

Android will do the same.

Backport of #22982.
@rolfbjarne rolfbjarne mentioned this pull request Jun 3, 2025
Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #ef243d3] Build passed (Build packages) ✅

Pipeline on Agent
Hash: ef243d35d362c9cf603729980bd9f80c110a0872 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #ef243d3] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: ef243d35d362c9cf603729980bd9f80c110a0872 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: ef243d35d362c9cf603729980bd9f80c110a0872 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #ef243d3] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: ef243d35d362c9cf603729980bd9f80c110a0872 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #ef243d3] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: ef243d35d362c9cf603729980bd9f80c110a0872 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #ef243d3] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: ef243d35d362c9cf603729980bd9f80c110a0872 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #ef243d3] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: ef243d35d362c9cf603729980bd9f80c110a0872 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #ef243d3] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: ef243d35d362c9cf603729980bd9f80c110a0872 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
1 similar comment
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
rolfbjarne added a commit that referenced this pull request Jun 3, 2025
@rolfbjarne
[release/9.0.1xx] Use 'EnableDiagnostics' instead of 'EnableProfiler'. (
c07b2b7 
#22983)

Ref: dotnet/runtime#115473 (comment)

Android will do the same.

Backport of #22982.
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #ef243d3] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. [attempt 4] Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: ef243d35d362c9cf603729980bd9f80c110a0872 [PR build]

@rolfbjarne rolfbjarne merged commit 8dd88d6 into main Jun 3, 2025
44 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/enable-diagnostics branch June 3, 2025 14:54
jonathanpeppers added a commit to dotnet/android that referenced this pull request Jun 3, 2025
@jonathanpeppers
[xabt] rename $(EnableProfiler) to $(EnableDiagnostics)
4e57383 
Context: dotnet/macios#22982
Context: dotnet/runtime#115473 (comment)

We are aligning WASM, iOS, Android to all use the same property name for this.
@jonathanpeppers jonathanpeppers mentioned this pull request Jun 3, 2025
Merged
jonathanpeppers added a commit to dotnet/android that referenced this pull request Jun 3, 2025
@jonathanpeppers
[xabt] rename $(EnableProfiler) to $(EnableDiagnostics) (#10166)
7ca5d16 
Context: dotnet/macios#22982
Context: dotnet/runtime#115473 (comment)

We are aligning WASM, iOS, Android to all use the same property name for this.
jonathanpeppers added a commit to dotnet/android that referenced this pull request Jun 3, 2025
@jonathanpeppers
[xabt] rename $(EnableProfiler) to $(EnableDiagnostics) (#10166)
712888d 
Context: dotnet/macios#22982
Context: dotnet/runtime#115473 (comment)

We are aligning WASM, iOS, Android to all use the same property name for this.
jonathanpeppers added a commit to dotnet/android that referenced this pull request Jun 5, 2025
@jonathanpeppers
[xabt] rename $(EnableProfiler) to $(EnableDiagnostics) (#10166)
9ca9d6d 
Context: dotnet/macios#22982
Context: dotnet/runtime#115473 (comment)

We are aligning WASM, iOS, Android to all use the same property name for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@emaf emaf emaf approved these changes

@mauroa mauroa Awaiting requested review from mauroa mauroa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @akoeplinger @emaf