Skip to content

[Foundation] Don't use ServicePointManager to get minimum TLS protocol. #22517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025
Merged

[Foundation] Don't use ServicePointManager to get minimum TLS protocol. #22517

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e4770f
[Foundation] Don't use ServicePointManager to get minimum TLS protocol.
rolfbjarne Apr 1, 2025
f9056fe
Merge remote-tracking branch 'origin/main' into dev/rolf/servicepoint…
rolfbjarne Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Foundation/NSUrlSessionHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ public NSUrlSessionHandler (NSUrlSessionConfiguration configuration)
allowsCellularAccess = configuration.AllowsCellularAccess;
AllowAutoRedirect = true;

#if !NET10_0_OR_GREATER
#pragma warning disable SYSLIB0014
// SYSLIB0014: 'ServicePointManager' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead. Settings on ServicePointManager no longer affect SslStream or HttpClient.' (https://aka.ms/dotnet-warnings/SYSLIB0014)
// https://github.com/xamarin/xamarin-macios/issues/20764
Expand All @@ -170,6 +171,7 @@ public NSUrlSessionHandler (NSUrlSessionConfiguration configuration)
configuration.TLSMinimumSupportedProtocol = SslProtocol.Tls_1_2;
else if ((sp & (SecurityProtocolType) 12288) != 0) // Tls13 value not yet in monno
configuration.TLSMinimumSupportedProtocol = SslProtocol.Tls_1_3;
#endif // NET10_0_OR_GREATER

session = NSUrlSession.FromConfiguration (configuration, (INSUrlSessionDelegate) new NSUrlSessionHandlerDelegate (this), null);
inflightRequests = new Dictionary<NSUrlSessionTask, InflightData> ();
Expand Down