Skip to content

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Sep 5, 2025

Description

I'm noticing some CI hangs on .Net Framework tests after #18875

The cause may or may not be thread pool starvation: old .Net uses different algorithms and does not ramp up threads fast enough.

Specifically after #18875 the type subsumption cache is tied to TcGlobals, which means more instances instead of one per process singleton. Unfortunately, in tests it means thousand started in quick succession. So, the queued eviction for each one eats some threads, quickly.

So, if the problem persists, this should be a fix.

Copy link
Contributor

github-actions bot commented Sep 5, 2025

❗ Release notes required

@majocha,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/10.0.100.md No release notes found or release notes format is not correct

@majocha majocha closed this Sep 5, 2025
@majocha majocha reopened this Sep 5, 2025
@majocha majocha marked this pull request as ready for review September 9, 2025 18:53
@majocha majocha requested a review from a team as a code owner September 9, 2025 18:53
@majocha
Copy link
Contributor Author

majocha commented Sep 9, 2025

I think this is needed after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants