Disable really noisy analyzers, part 1 #6837
Merged
+55
−721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are super annoying and add basically zero value.
github-actions
bot
added
the
area-ai-eval
There was a problem hiding this comment.
Pull Request Overview
This pull request aims to disable a set of code analysis rules that the author considers "super annoying and add basically zero value." The changes involve removing pragma warning directives and adjusting analyzer configurations to make these rules less intrusive by changing their severity from warning to suggestion.
- Removal of pragma warning directives throughout the codebase for multiple analyzer rules
- Update to
.editorconfigto change severity levels for various code analysis rules fromwarningtosuggestion - Modifications to project files to remove specific rule suppressions
Reviewed Changes
Copilot reviewed 165 out of 165 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Multiple C# source files | Removed pragma warning disable/restore directives for various analyzer rules |
| src/Libraries/.editorconfig | Changed severity levels for multiple analyzer rules from warning to suggestion |
| Multiple .csproj files | Removed specific NoWarn entries for various analyzer rules |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
eiriktsarpalis
approved these changes
Sep 24, 2025
evgenyfedorov2
approved these changes
Sep 24, 2025
stephentoub
added
area-infrastructure
and removed
area-ai-eval
peterwald
approved these changes
Sep 24, 2025
stephentoub
force-pushed
the
noisyanalyzers1
branch
from
b6dcba9 to
a75b78c
Compare
shyamnamboodiripad
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are super annoying and add basically zero value.
Microsoft Reviewers: Open in CodeFlow