Add more openai conversion helpers #6662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds several OpenAI conversion helper methods to enable bidirectional conversion between Microsoft.Extensions.AI types and OpenAI types. The changes enhance interoperability by providing methods to convert chat messages, responses, and completions in both directions.
Key changes include:
- Added conversion methods for ChatMessage collections to/from OpenAI types
- Added conversion from ChatResponse to OpenAI ChatCompletion
- Refactored common conversion logic into shared helper methods
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
OpenAIConversionTests.cs |
Comprehensive test coverage for new conversion methods including edge cases and error handling |
OpenAIResponsesChatClient.cs |
Refactored message conversion logic into reusable methods and improved raw representation handling |
OpenAIClientExtensions.cs |
Added shared helper methods for parsing function call content from JSON |
OpenAIChatClient.cs |
Enhanced content conversion methods and improved raw representation processing |
OpenAIAssistantsChatClient.cs |
Updated to use new shared function call parsing methods |
MicrosoftExtensionsAIResponsesExtensions.cs |
Added new extension methods for converting between response types |
MicrosoftExtensionsAIChatExtensions.cs |
Added comprehensive bidirectional conversion methods for chat messages and completions |
test/Libraries/Microsoft.Extensions.AI.OpenAI.Tests/OpenAIConversionTests.cs
Outdated
Show resolved
Hide resolved
test/Libraries/Microsoft.Extensions.AI.OpenAI.Tests/OpenAIConversionTests.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.OpenAI/MicrosoftExtensionsAIChatExtensions.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.OpenAI/MicrosoftExtensionsAIResponsesExtensions.cs
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Jul 30, 2025
This was referenced Aug 14, 2025
Closed
Closed
This was referenced Aug 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow